dub icon indicating copy to clipboard operation
dub copied to clipboard

Added start and end date optional params added to analytics endpoint

Open UsmanDev09 opened this issue 10 months ago • 1 comments

fixes #749

Description:

The endpoint analytics/[endpoint] now accepts startDate and endDate as optional params in ISO Date Time Format yyyy-MM-dd'T'HH:mm:ss. SSSXXX. I've added few checks too:

  1. Start Date should be after 22 September, 2022
  2. End Date cannot be in future
  3. Either interval or start and end date can be provided, not both

P.S. Once the PR is merged, I'll update the docs and add an option in the UI to filter analytics by providing custom dates.

UsmanDev09 avatar Apr 17 '24 13:04 UsmanDev09

@UsmanDev09 is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 17 '24 13:04 vercel[bot]

@UsmanDev09 this looks great. Is there anything else needed to ship it?

jmagentio avatar May 06 '24 14:05 jmagentio

@jmagentio Nope, it's complete

UsmanDev09 avatar May 06 '24 17:05 UsmanDev09

@steven-tey is this the branch and implementation you are hoping to support start and end dates with for analytics?

jmagentio avatar May 06 '24 21:05 jmagentio

@jmagentio yes we're reviewing this PR currently cc: @devkiran

steven-tey avatar May 07 '24 12:05 steven-tey

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dub ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 1:01pm

vercel[bot] avatar May 08 '24 20:05 vercel[bot]

Thanks! Do you want me to update the docs and add the option to filter analytics with custom dates in the UI in a separate PR? @steven-tey

UsmanDev09 avatar May 08 '24 21:05 UsmanDev09

@UsmanDev09 docs should be updated automatically! Let's hold off on the custom client side filter for now – we want to explore something that's mobile friendly + supports presets :)

steven-tey avatar May 09 '24 12:05 steven-tey