dub icon indicating copy to clipboard operation
dub copied to clipboard

Skip tracking if there is a `gclid` param

Open devkiran opened this issue 11 months ago • 1 comments

devkiran avatar Apr 02 '25 16:04 devkiran

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dub ✅ Ready (Inspect) Visit Preview Jun 30, 2025 2:36am

vercel[bot] avatar Apr 02 '25 16:04 vercel[bot]

Walkthrough

This change introduces a system for tracking, querying, and reporting partner activities, particularly suspicious ones, across various components. It adds new APIs, data pipelines, middleware logic, utility functions, email templates, and database schemas to support weekly summary emails about partner activities to program owners, including integration with Google Ads click detection and activity recording.

Changes

File(s) / Group Change Summary
apps/web/app/api/cron/partners/activity-summary/route.ts Added GET route for weekly partner activity summary emails, including logic for data fetching and email sending
apps/web/lib/middleware/link.ts Enhanced middleware to detect Google Ads clicks, conditionally record partner activities
apps/web/lib/tinybird/get-partner-activities.ts New module exporting a typed, validated Tinybird pipeline for querying partner activities
apps/web/lib/tinybird/record-partner-activity.ts New module to validate and record partner activity events to Tinybird
apps/web/lib/url.ts Added utility function to detect Google Ads clicks via the gclid parameter
packages/email/src/templates/partner-activity-summary.tsx New React email template for weekly partner activity summary reports
packages/tinybird/datasources/dub_partner_activities.datasource New Tinybird datasource schema for partner activities
packages/tinybird/pipes/get_partner_activities.pipe New Tinybird pipe for querying recent partner activities by program

Sequence Diagram(s)

sequenceDiagram
    participant CronJob as Cron Scheduler
    participant API as /api/cron/partners/activity-summary
    participant DB as Database
    participant Tinybird as Tinybird API
    participant Email as Email Service

    CronJob->>API: GET /api/cron/partners/activity-summary
    API->>DB: Fetch all programs
    loop For each program
        API->>Tinybird: getPartnerActivities(programId, startDate, endDate)
        Tinybird-->>API: Partner activities data
        API->>DB: Fetch partner details & program owners
        loop For each owner
            API->>Email: Send summary email (with activities)
        end
    end
    API-->>CronJob: JSON "OK" response
sequenceDiagram
    participant User as User
    participant Middleware as Link Middleware
    participant Tinybird as Tinybird API

    User->>Middleware: Clicks partner link
    Middleware->>Middleware: Check if Google Ads click (gclid)
    alt Google Ads click & partner link
        Middleware->>Tinybird: recordPartnerActivity(type="google-ads")
    end
    Middleware-->>User: Redirect/Rewrite URL (conditionally with via param)

Suggested reviewers

  • devkiran

Poem

A bunny with code on its mind,
Watched partners and programs aligned.
With emails that hop,
And clicks that don't stop,
Suspicious or not, all are signed!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55ebb1ad4d83d628e66a6f41bfed2745028d7bfb and 627bc9adb1435b5fc1efc4219ff2930dae391f54.

📒 Files selected for processing (1)
  • apps/web/lib/middleware/link.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/web/lib/middleware/link.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 09 '25 16:06 coderabbitai[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 09 '25 17:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 09 '25 17:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 09 '25 17:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 09 '25 17:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 09 '25 21:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 10 '25 03:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 11 '25 04:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 12 '25 01:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 12 '25 02:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 12 '25 02:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 12 '25 03:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 19 '25 04:06 bug0-qa-agent[bot]

🤖 Bug0 QA Agent

Here are the results of the automated tests for PR #2250:

To re-run the tests, please comment /bug0 run or push a new commit to this PR.

bug0-qa-agent[bot] avatar Jun 19 '25 17:06 bug0-qa-agent[bot]

Closing this in favor of #2688

devkiran avatar Jul 31 '25 03:07 devkiran