dub icon indicating copy to clipboard operation
dub copied to clipboard
verified publisher icon dubinc

fix: redirection to login page on cancelling of consent of oauth providers

Open garvitkhandelwal opened this issue 1 year ago • 12 comments

Summary

Fixes #1429 This PR aims to fix the issue which is raised under #1429. To summarise the issue here, when a user selected any OAuth provider to log in but then cancels on the permission page, it was not getting redirected to the default login page. This issue was instead causing the redirection to be handled via the nextauth's default redirection mechanism since it was not able to find our own signin route. More details on the issue can be found in the issue link added above.

Changes

Added a signIn route in the pages configuration of nextAuth options.

Screenshot/Video of the fix:

https://github.com/user-attachments/assets/45723130-0298-4229-a16d-4e821d7143c3

References:

https://github.com/nextauthjs/next-auth/discussions/3682

garvitkhandelwal avatar Oct 13 '24 02:10 garvitkhandelwal

@garvitkhandelwal is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 13 '24 02:10 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 13 '24 02:10 CLAassistant

/assign

mokshi2469 avatar Oct 13 '24 05:10 mokshi2469

The /assign command can only be used on issues, not on pull requests.

oss-gg[bot] avatar Oct 13 '24 05:10 oss-gg[bot]

/assign

AlfrinP avatar Oct 13 '24 06:10 AlfrinP

The /assign command can only be used on issues, not on pull requests.

oss-gg[bot] avatar Oct 13 '24 06:10 oss-gg[bot]

/assign

lokeshgaria avatar Oct 13 '24 06:10 lokeshgaria

The /assign command can only be used on issues, not on pull requests.

oss-gg[bot] avatar Oct 13 '24 06:10 oss-gg[bot]

The /assign command can only be used on issues, not on pull requests.

oss-gg[bot] avatar Oct 13 '24 13:10 oss-gg[bot]

Hey @garvitkhandelwal Please update your branch , it is out-of-date with the base branch

Done

garvitkhandelwal avatar Oct 13 '24 17:10 garvitkhandelwal

/assign

lostinvsc avatar Oct 14 '24 08:10 lostinvsc

The /assign command can only be used on issues, not on pull requests.

oss-gg[bot] avatar Oct 14 '24 08:10 oss-gg[bot]

@steven-tey apologies for tagging but is there anything I need to do to get this PR reviewed? I'm unable to get other oss.gg issues assigned to myself until this one is resolved.

garvitkhandelwal avatar Oct 14 '24 18:10 garvitkhandelwal

@garvitkhandelwal taking a look now!

steven-tey avatar Oct 14 '24 18:10 steven-tey

Awarding garvitkhandelwal: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/garvitkhandelwal

oss-gg[bot] avatar Oct 14 '24 19:10 oss-gg[bot]