Lucas Duailibe
Lucas Duailibe
FYI we use the Glimmer parser that does the parsing of code that combines Handlebars + HTML (the Handlebars parser doesn't support HTML), but that parser does not support all...
Indeed. Why do we only inline array and objects when they're not empty? i.e. ```js const foo = bar && baz && []; const foo = bar && baz &&...
Okay now I get why it's like this.. goes back to #1342 but I'm not sure the fix was correct (i.e. the example above)
As we'll focus the discussion on this issue, I'll copy my comment from the other thread (cc @lipis): The thing about template literals is without breaking between `{` and `}`...
> Discouraging messes is the job of a linter, not a formatter The job of a formatter is to format the code, whether or not it's a mess, trying its...
@JonathanWolfe We used to not format and we changed it because a LOT of people expected the code to be formatted there as well. So it's not an option to...
Yeah that's an option.. If we simply remove the linebreaks, that would be formatted as: ```js const foo = `some text here ${foo .bar.baz} continues here`; ``` Which is worse...
Thanks! I can take a shot at a PR today (actually already done it in a fork that I'm using and I can try to contribute it upstream). Do you...
Throwing a `ValiError` in `transform` seems like a good alternative and easy to add, I just don't like very much the lack of parity between pipeline and transformations (but maybe...
@fabian-hiller the problem with that approach is running the same code twice (once for validation, other for transformation). For the JSON case that would be fine (and a new type...