react-skroll icon indicating copy to clipboard operation
react-skroll copied to clipboard

native scrollTop/Left

Open drcmda opened this issue 7 years ago • 1 comments

This looks like a really useful lib! Browsed through the code a little and noticed it uses onFrame to update scroll position. I think it was react-spring 5 that introduced native support to animate scrollTop/Left, see: https://codesandbox.io/embed/wo59nvw3p7 And the other way round, reacting to scroll position: https://codesandbox.io/embed/py912w5k6m

That would remove some complexity and perhaps make it easier to add features. 😊

drcmda avatar Dec 22 '18 12:12 drcmda

@drcmda I am working on PR that changes from animating scrollTop/Left to css transforms... I did check the examples you sent, but animating scrollTop/Left is very buggy on Android-Chrome. That was my main motivation to change to transforms. Thanks for the input!

arturmiglio avatar Dec 28 '18 19:12 arturmiglio