Don Turner issues

Results 104 issues of


                                            Don Turner

Rename smurf named methods

Here's what I've done and why: - Removed `Task` from `TaskRepository` methods to avoid smurf naming e.g `createTask` becomes just `create`. - Changed `get` to `observe` for methods which return...

Tests should use `assertEquals` for consistency

Move mapping functions into different packages/classes

See https://github.com/android/architecture-samples/pull/908#discussion_r1127589401

[Feature request] Provide a Compose UI element to view open source licenses

[Compose](https://developer.android.com/jetpack/compose) is the recommended UI framework for new apps. Currently the Open Source License plugin only provides an Activity, which is dependent on `Theme.AppCompat`. This means a lot of extra...

Update Spotless and ktlint - Code style rule changes

**What have I done and why** tl;dr I have updated spotless and ktlint versions, however, this has resulted in some code style rule changes. This PR is to discuss: -...

Replace kapt with ksp, update versions

Use event queue to avoid heap allocated coroutineScope

**What have I done and why** Added a queue for network sync events, implemented using a `Channel`. This avoids having a heap allocated coroutine scope which might fail silently.

First attempt at improving accessibility on ForYouScreen

**What I have done and why** Attempting to improve accessibility on ForYouScreen. I have a few outstanding issues: - Despite adding a custom action ([as per this video](https://youtu.be/iV0h_6G3CYk?si=W19l0-2Q0VljFUEr&t=210)) the `NiaIconToggleButton`...

Build warnings: 'enableAndroidTest: Boolean' is deprecated

``` > Task :build-logic:convention:compileKotlin w: file:///Users/donturner/Code/workspace-android/nowinandroid/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidInstrumentedTests.kt:33:8 'enableAndroidTest: Boolean' is deprecated. replaced with enableAndroidTest w: file:///Users/donturner/Code/workspace-android/nowinandroid/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidInstrumentedTests.kt:33:31 'enableAndroidTest: Boolean' is deprecated. replaced with enableAndroidTest ```

good first issue

Use of `UnconfinedTestDispatcher` is discouraged

Investigate use of `UnconfinedTestDispatcher` in tests as in most cases it can be replaced with `advanceUntilIdle()` which gives tighter control over job execution.