redux-bug-reporter icon indicating copy to clipboard operation
redux-bug-reporter copied to clipboard

React 16 support

Open akoenig opened this issue 7 years ago • 7 comments

Hi @dtschust, thanks for building redux-bug-reporter! I have one question though. Do you have any plans to support React 16 in order to get rid of the deprecation warning regarding React.createClass in React 15.5?

akoenig avatar Jun 07 '17 10:06 akoenig

Hi @akoenig , thanks for asking! Yes, I plan to support React 16 eventually, but I'm not spending a lot of time lately on redux-bug-reporter. I'll probably look into it once React 16 launches. I also accept PRs if you'd like to take a crack at it!

dtschust avatar Jun 11 '17 17:06 dtschust

Awesome! :) Now where React 16 landed, do you have time for that? :)

akoenig avatar Sep 29 '17 12:09 akoenig

Hi @akoenig , I'll try and get to this in the next few weeks, but am also willing to accept PRs if you need it more urgently :)

dtschust avatar Sep 29 '17 21:09 dtschust

@akoenig I've got a rough branch that I think seems to be working fine with React 16, although my unit tests are failing due to some bugs in the newest version of enzyme. The commits are all over the place and I'll tidy them up before merging, but I'd love feedback if you can confirm how it works for you: https://github.com/dtschust/redux-bug-reporter/tree/bump-versions

dtschust avatar Oct 03 '17 21:10 dtschust

Ah @dtschust, that is awesome. Thanks for putting time into it and sorry that my request seemed a bit needy. I just hadn‘t the time to compile the PR 😕

I will work on an app that has to be migrated to React 16 and which uses the Redux Bug Reporter in the next week. Will be able to test the branch then.

Thanks a thousand times for your efforts!

akoenig avatar Oct 04 '17 17:10 akoenig

@dtschust Where did you guys leave off with this?

jrball3 avatar May 17 '18 20:05 jrball3

@jrball3 sorry, but I'm not actively maintaining this package at the moment. I have an abandoned work in progress branch as listed above that should work with React 16 if you want to try that!

dtschust avatar May 18 '18 18:05 dtschust