unit-e icon indicating copy to clipboard operation
unit-e copied to clipboard

Check difficulty in ContextualCheckBlockHeader

Open scravy opened this issue 6 years ago • 1 comments

LegacyValidationInterface::ContextualCheckBlockHeader does not check difficulty.

#939 might fix that, or a smaller patch can just patch this in.

@Ruteri inintially reported, I'm aware of it, but lets not forget about it.

scravy avatar Apr 12 '19 07:04 scravy

Actually, whether the difficulty is met is correctly checked in CheckStake, as difficulty affects eligibility of a coin. This check does not rely on nBits in the header. In fact, this value is never read. That is to say, we could actually drop it form the header.

scravy avatar Apr 16 '19 13:04 scravy