unit-e
unit-e copied to clipboard
Open Items PoS transition
- Restore functional tests that relied on BIP 22 and BIP 23: https://github.com/dtr-org/unit-e/issues/280 (important in general and to merge with upstream 0.17)
- [ ] Adapt
generateRPC call (important to have functional tests working with new PoS setting, 0.1)- be aware:
generateis being deprecated in bitcoin andgeneratetoaddressshould be used - currently generate mines blocks on lowest difficulty, new generate requires a wallet to sign transactions/blocks
- preliminary work for this has been done in: https://github.com/dtr-org/unit-e/pull/613
- is being done in #738
- be aware:
- [ ] Make sure BIP9 works/works again (correct version has to be set in
staking::BlockBuilder, right now it just sets something (dunno, 1, or 2).- Related: https://github.com/dtr-org/unit-e/issues/472
- We do not want to have the current softforks enabled as softforks as we do support them by default, but we do want to support BIP9 for future compatibility with bitcoin (probably, see discussion)
- BIP9: https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki
- [ ] Duplicate Stake Attack Protection: (1.0)
- https://github.com/dtr-org/unit-e/issues/416
- we do have some preparations for it in
StakeValidator - in particl they have an
nFlagsmember onCBlockwhich is used to check this and propagate it do different parts of the core software
- [ ] Store or recompute
stake_amount/chain_stakeinCBlockIndexor differently (1.0)- https://github.com/dtr-org/unit-e/issues/534
- bitcoin uses
nChainWork - is supposed to become
chain_stake - interacts with ABC (ActivateBestChain)
- Store or recompute
stake_modifierinCBlockIndexor differently (1.0)- https://github.com/dtr-org/unit-e/issues/535
Restore functional tests that relied on BIP 22 and BIP 23: #280 (important in general and to merge with upstream 0.17)
Done.
Related issues: https://github.com/dtr-org/unit-e/issues/280 and https://github.com/dtr-org/unit-e/issues/283.