David Tolnay

Results 794 comments of David Tolnay

IMO this should be handled in a cross-platform way by the compiler, not by wasm-ld. If you are motivated to work on this, here is an outline: https://internals.rust-lang.org/t/from-life-before-main-to-common-life-in-main/16006/25?u=dtolnay

Yeah the layout algorithm changed in Rust 1.74 due to https://github.com/rust-lang/rust/pull/115277. Thanks for reporting.

@bors r=joshtriplett,dtolnay

I am on board with a PR to relocate the number parsing logic, if justified by a benchmark. However, I am opposed to turning our Read trait's details into a...

Context: this was a default feature in hashbrown 0.14.3 at the time of https://github.com/kyren/hashlink/pull/28, so it makes sense for that PR (which was focused on something different) to have kept...

Arbitrary unsafe functions are not exposed to Rust. The FFI has a list of the C++ functions that need to be reviewed, like this: https://github.com/dtolnay/cxx/blob/1822e22523fd02ee2655ad686241385fef56025e/demo/src/main.rs#L18-L25 and I can examine just...

Whether a function is safe to call from Rust is determined by whether the `fn` is unsafe, not the surrounding block. This function would be unsafe to call from Rust:...

> Are you saying CXX doesn't allow other C++ functions (e.g. `vector::pop_back()`) to be exposed to Rust? How could it possibly prevent that? CXX does allow other C++ functions to...

> 8259 contains one new sentence: “JSON text exchanged between systems that are not part of a closed ecosystem MUST be encoded using UTF-8 [RFC3629].” The difference between these standards...

You can use https://docs.rs/build-alert for warnings that show up inside ordinary crates.io dependencies.