rockscache icon indicating copy to clipboard operation
rockscache copied to clipboard

fetchBatch在panic时没有释放锁

Open slowargo opened this issue 1 year ago • 1 comments

https://github.com/dtm-labs/rockscache/blob/main/batch.go#L44 defer func() { if r := recover(); r != nil { debug.PrintStack() } }() 当fn发生panic,这个地方虽然recover了,但没有释放锁,其他等锁的请求会被阻塞直到锁过期 另外这个debug.PrintStack()也不太友好,没办法把context里的额外信息打印出来,不好捞panic日志,是否可以考虑让业务方自己提供panic handler

slowargo avatar Sep 10 '24 07:09 slowargo

PR is welcome

yedf2 avatar Nov 24 '24 01:11 yedf2