rockscache icon indicating copy to clipboard operation
rockscache copied to clipboard

feat: codec

Open exuan opened this issue 2 years ago • 2 comments

add FetchWithCodec

exuan avatar Sep 15 '23 14:09 exuan

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 84.73%. Comparing base (a01baf8) to head (9b4ceb2).

:exclamation: Current head 9b4ceb2 differs from pull request most recent head 8d2ba8e. Consider uploading reports for the commit 8d2ba8e to get more accurate results

Files Patch % Lines
client.go 66.66% 5 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   84.18%   84.73%   +0.55%     
==========================================
  Files           3        4       +1     
  Lines         373      452      +79     
==========================================
+ Hits          314      383      +69     
- Misses         42       50       +8     
- Partials       17       19       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 15 '23 14:09 codecov-commenter

为什么这个要单独加一个函数呢?直接在Fetch2里面实现这个特性看起来是可行的。只需要默认的codec行为跟原先相同即可

yedf2 avatar Sep 23 '23 15:09 yedf2