Dave Thaler
Dave Thaler
@mstemm can you confirm?
Agreed
> I'm probably missing something, but aren't the instructions atomic because they change memory regions that are already volatile? Apparently atomic operations can also work on _stack_ memory. Not that...
> Looks good in general. See my question about the choice of fields though. I think I've now made changes according to all your comments. Please re-review. Thanks!
@shpalani asked: > Is it possible to get an update on sync_fetch_and_add/lock_xadd support? It is needed for ebpf-for-windows. Ok, pull request is now ready for review.
> Does this need a rebase now? Done, just in case.
> * `.c_str()` is never needed here. We can also use [std::format()](https://en.cppreference.com/w/cpp/utility/format/format) for simplification, either now or in a future PR. Github's ["ubuntu-latest" runner](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md) supports clang 15. Clang 15 [support...
> * This is an opportunity to have uniform capitalization too. I suggest all-lowercase. Done
> Does EBPF runtime guarantee little-endianness? No. But the CI/CD tests, as well as the ebpf-for-windows runtime, today only runs on little-endian machines.
> So endiannes needs to be a parameter, no? Agreed. I may or may not get to this for a couple of days though, busy at a convention right now.