chocolatey-packages icon indicating copy to clipboard operation
chocolatey-packages copied to clipboard

Published 20 hours ago • verified publisher icon dtgm

(Install4J) now maintained by tunisiano

Open tunisiano187 opened this issue 10 months ago • 2 comments

Hello, I've missed the portable one, i'll prepare it and ask for it too.

tunisiano187 avatar Mar 31 '24 13:03 tunisiano187

Added

tunisiano187 avatar Mar 31 '24 14:03 tunisiano187

I will hold off on merging this one until you push a new package version.

gep13 avatar Apr 15 '24 06:04 gep13

@tunisiano187 this PR looks good, but I noticed that you haven't pushed the updated metapackage install4j. Is that something that you are still planning on doing?

gep13 avatar May 20 '24 06:05 gep13

It's indeed what it should do, but, it was stuck... i've tryied something else

tunisiano187 avatar May 20 '24 10:05 tunisiano187

This correction worked, it's been pushed

tunisiano187 avatar May 20 '24 11:05 tunisiano187

@tunisiano187 thanks for checking!

Happy to approve the package, as it is just a refresh of the existing package scripts, however, for future versions, you might want to think about removing the chocolateyUninstall.ps1 from the meta package, as this should no longer be required, as Chocolatey CLI will take care of that.

gep13 avatar May 20 '24 11:05 gep13

@tunisiano187 thanks again for your help with this package, and all the other packages that you are working on!

gep13 avatar May 20 '24 11:05 gep13