WebToEpub icon indicating copy to clipboard operation
WebToEpub copied to clipboard

Royal road - download issues

Open shreyassv opened this issue 10 months ago • 6 comments

Describe the bug Sometimes , even though there are no errors , and the plugin shows that all chapters have been downloaded, the file is not saved.

To Reproduce Steps to reproduce the behavior:

  1. Go to royalroad fic'
  2. Use webtoepub to create ebook.
  3. after all chapters are worked on, the file is not created- webtoepub appears to be stuck in a loop.
  4. inspect shows the following error-uncaught in promise - range error maximum call stack size exceeded

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: windows 11
  • Browser chrome
  • Version [e.g. 22]

shreyassv avatar Feb 03 '25 07:02 shreyassv

@shreyassv

Can you figure out the conditions needed to consistently reproduce the problem?

dteviot avatar Feb 03 '25 07:02 dteviot

Selecting skip images and deselecting the other two image related checkbox solves the problem.

This issue has occurred with images downloaded for 2 royalroad stories for me. The one linked in the issue is one. I don’t remember the other. I’ll find and upload the other later.

The issue is that most stories have the image as part of the story(status etc)

shreyassv avatar Feb 03 '25 08:02 shreyassv

@dteviot

Selecting skip images and deselecting the other two image related checkbox solves the problem.

This issue has occurred with images downloaded for 2 royalroad stories for me. The one linked in the issue is one. I don’t remember the other. I’ll find and upload the other later.

The problem is that most stories have the image as part of the story(status etc)

shreyassv avatar Feb 03 '25 10:02 shreyassv

I can reproduce the error:

Image

I think there exists another issue with the same problem but i can't find it.

The Network tab:

Image

gamebeaker avatar Feb 03 '25 11:02 gamebeaker

@shreyassv

The problem is that most stories have the image as part of the story(

Sounds like the problem is the images are taking up too much memory. Possible solution would be for you to download the story in blocks of 50 chapters or so at a time. Then merge the chapters together.

dteviot avatar Feb 03 '25 18:02 dteviot

@shreyassv

The problem is that most stories have the image as part of the story(

Sounds like the problem is the images are taking up too much memory. Possible solution would be for you to download the story in blocks of 50 chapters or so at a time. Then merge the chapters together.

I tried that- same issue even with just 2 chapters. Kept decreasing chapters- went to 50. Then tried 20,10,5 and finally 2. Same issue. Same error.

shreyassv avatar Feb 03 '25 19:02 shreyassv

@shreyassv the problem is that there is a gif that is 48 MB big and this is to big in the first Chapter at the bottom.

gamebeaker avatar Feb 27 '25 15:02 gamebeaker

Note to self, look at replacing jszip with archiver https://npm-compare.com/adm-zip,archiver,jszip,zip-local Nope. non-stater. It for Node.js. Won't work with Chrome.

dteviot avatar Feb 27 '25 22:02 dteviot

I am going to look into this https://github.com/gildas-lormeau/zip.js

gamebeaker avatar Feb 28 '25 19:02 gamebeaker

Is it possible to leave out images on specific chapters alone? Or to automatically not use large images instead of a blanket ban on images?Sent from my iPhoneOn 27 Feb 2025, at 8:55 PM, gamebeaker @.> wrote: @shreyassv the problem is that there is a gif that is 48 MB big and this is to big in the first Chapter at the bottom.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>

gamebeaker left a comment (dteviot/WebToEpub#1665) @shreyassv the problem is that there is a gif that is 48 MB big and this is to big in the first Chapter at the bottom.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

shreyassv avatar Mar 01 '25 05:03 shreyassv

@shreyassv i am working on a fix in #1692 at the moment the base version works and i was able to create an epub with a size of 210 MB from https://www.royalroad.com/fiction/82881/madman-apocalypse

gamebeaker avatar Mar 01 '25 21:03 gamebeaker

@shreyassv

Test versions for Firefox and Chrome have been uploaded to https://github.com/dteviot/WebToEpub/releases/tag/developer-build. Pick the one suitable for you, follow the "How to install from Source" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-installation and let me know how it goes.

gamebeaker avatar Mar 07 '25 15:03 gamebeaker

@shreyassv

Updated version (1.0.3.0) has been submitted to Firefox and Chrome stores. Firefox version is available now. Chrome might be available in a few hours (typical) to 21 days.

dteviot avatar Mar 09 '25 05:03 dteviot