dterrahe

Results 90 comments of dterrahe

> Before anyone misunderstands: I'm not arguing, I'm asking. No worries at all! I prefer more questions rather than less. The more people understand and think about this stuff, the...

Does _create_basic_curve_controls_box get called from gui_init, where reset>0, or only later? That would also probably mean that shortcuts/actions don't get set up for those widgets? On phone so can't research...

> the setters eventually end up in _slider_set_normalized, and there _slider_value_change is not called if 'reset' is on. Exactly. That's what mystified me. > was unable to crash it again...

The event loop is running, but since we're _in_ the event loop, we're the one blocking it. So it will be unresponsive until we return, which is why we're showing...

I'm getting these btw ``` 1.5892 connecting signal value-changed to handler with wrong return type /home/diederik/darktable/src/gui/gtk.c:1464 1.5893 connecting signal value-changed to handler with wrong return type /home/diederik/darktable/src/gui/gtk.c:1468 2.2737 connecting signal...

Sure. This is a developer diagnostic tool. It can be used locally without needing to be merged upstream. What I meant is that you might still consider applying fixes for...

CI obviously fails, because you need gtk4 libs installed to compile/run.

> How can we coordinate things to avoid overlapping work? So, practically, as I described I see this going in two phases; one a sort-of preparation phase where I keep...

Event translation layer in `g_signal_connect_data`. No longer need to add legacy signal handlers to all our own classes. Down to one page of connection errors. The idea would be that...