bevy_pixels icon indicating copy to clipboard operation
bevy_pixels copied to clipboard

feat!: make compatible with `bevy@~0.14`

Open waynevanson opened this issue 1 year ago • 4 comments

I got close but not close enough, using the branch https://github.com/mkrasnitski/pixels from the PR https://github.com/parasyte/pixels/pull/391 via the patches in cargo.

  • Blocked by https://github.com/parasyte/pixels/pull/391
  • Closes #22
  • Pixels added a lifetime to the struct so we need to add one too. Not sure if <'win: 'static> is the way to go. Bevy query types want 'static but figured allowing our own lifetime bound by static is better than just static.

I can't figure out the error in src/system.rs. It says that the window we get on line 33 doesn't have the trait HasWindowHandle. I believe it should be on there because we've added the feature rwh_06.

Feel free to add to or change this as you wish!

waynevanson avatar Sep 06 '24 07:09 waynevanson

FWIW, https://github.com/parasyte/pixels/pull/391 was merged today.

parasyte avatar Sep 22 '24 23:09 parasyte

FWIW, parasyte/pixels#391 was merged today.

Thanks @parasyte! I'll look at getting bevy_pixels working with bevy 0.14 and pixels 0.14.

dtcristo avatar Sep 22 '24 23:09 dtcristo

I haven't yet published a pixels release that supports wgpu 0.19, but I will be glad to if it will unblock this PR.

parasyte avatar Sep 23 '24 00:09 parasyte

I haven't yet published a pixels release that supports wgpu 0.19, but I will be glad to if it will unblock this PR.

@parasyte Ahh, so the new release of pixels 0.14 just bumps to wgpu 0.17 while it's the PR you mentioned that brings you to wgpu 0.19 with support for raw-window-handle 0.6 (yet to be included in a release)? I just noticed pixels 0.14 was just released and assumed it was included.

It would be nice to get this into a release, but no rush. More than happy to wait until those changes have been battle tested first.

dtcristo avatar Sep 23 '24 06:09 dtcristo

is there anything else blocking the upgrade? We just need a new version of pixels to bump the version. right?

dc740 avatar Nov 24 '24 19:11 dc740

Merged into feature branch so I can continue.

dtcristo avatar Mar 27 '25 02:03 dtcristo