lazy.js icon indicating copy to clipboard operation
lazy.js copied to clipboard

Avoid eval in cloneRegex

Open Deide opened this issue 8 years ago • 2 comments

The main reason to replace eval is for better static analysis. Build tools such as rollup spit warnings about the use of local eval.

Not only that, but eval seems to be slower in some situations. It's also a lot faster to just return the passed in RegExp if it has the global flag already set - no need to "clone".

Deide avatar Apr 23 '16 12:04 Deide

Why hasn't this been merged yet?

Announcement avatar Jun 22 '17 12:06 Announcement

What's the plan with this pull request?

eddietejeda avatar Mar 28 '19 01:03 eddietejeda