terraforming icon indicating copy to clipboard operation
terraforming copied to clipboard

Finishing lambda support

Open davidbegin opened this issue 7 years ago • 10 comments

I have been using this locally for a couple of weeks now, and thanks to @mattgartman's hard work it has been saving me lots of time.

Hopefully it will help others also.

davidbegin avatar Jul 12 '17 18:07 davidbegin

Coverage Status

Coverage decreased (-0.08%) to 99.922% when pulling 191d94c30a064fff2e16f8c1947d6e534c8e77f0 on davidbegin:finishing-lambda-support into 80610794c89fb985ca0f1e562cda850a14b762fc on dtan4:master.

coveralls avatar Jul 12 '17 18:07 coveralls

Coverage Status

Coverage decreased (-0.08%) to 99.922% when pulling 191d94c30a064fff2e16f8c1947d6e534c8e77f0 on davidbegin:finishing-lambda-support into 80610794c89fb985ca0f1e562cda850a14b762fc on dtan4:master.

coveralls avatar Jul 12 '17 18:07 coveralls

Coverage Status

Coverage decreased (-0.04%) to 99.961% when pulling 836dd76717e9f548b3f5d8e3fab83b3a04141888 on davidbegin:finishing-lambda-support into 80610794c89fb985ca0f1e562cda850a14b762fc on dtan4:master.

coveralls avatar Jul 12 '17 19:07 coveralls

Coverage Status

Coverage decreased (-0.04%) to 99.961% when pulling 8ded6831dbdad027bb27772db5a7d83830ab1953 on davidbegin:finishing-lambda-support into 80610794c89fb985ca0f1e562cda850a14b762fc on dtan4:master.

coveralls avatar Jul 12 '17 19:07 coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling 23c99c59bb445d6d423266e4ee6ce9b0ca09392f on davidbegin:finishing-lambda-support into 80610794c89fb985ca0f1e562cda850a14b762fc on dtan4:master.

coveralls avatar Jul 12 '17 20:07 coveralls

hey @dtan4 is there anything else you'd like me to do before this is mergeable?

I was going to take a look at adding support for one of the other resources I need, but wanted to make sure this was wrapped up first.

davidbegin avatar Jul 18 '17 16:07 davidbegin

I am waiting for this PR to be merged and released soon 👍

WayneYe avatar Sep 19 '17 22:09 WayneYe

downlaoded the pull request and when tried to run it the following is the error terraforming lf Traceback (most recent call last): 10: from /usr/local/bin/terraforming:23:in

' 9: from /usr/local/bin/terraforming:23:in load' 8: from /usr/local/lib/ruby/gems/2.5.0/gems/terraforming-0.16.0/bin/terraforming:5:in <top (required)>' 7: from /usr/local/lib/ruby/gems/2.5.0/gems/thor-0.19.4/lib/thor/base.rb:444:in start' 6: from /usr/local/lib/ruby/gems/2.5.0/gems/thor-0.19.4/lib/thor.rb:369:in dispatch' 5: from /usr/local/lib/ruby/gems/2.5.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in invoke_command' 4: from /usr/local/lib/ruby/gems/2.5.0/gems/thor-0.19.4/lib/thor/command.rb:27:in run' 3: from /usr/local/lib/ruby/gems/2.5.0/gems/terraforming-0.16.0/lib/terraforming/cli.rb:135:in lf' 2: from /usr/local/lib/ruby/gems/2.5.0/gems/terraforming-0.16.0/lib/terraforming/cli.rb:250:in execute' 1: from /usr/local/lib/ruby/gems/2.5.0/gems/terraforming-0.16.0/lib/terraforming/cli.rb:263:in tf' /usr/local/lib/ruby/gems/2.5.0/gems/terraforming-0.16.0/lib/terraforming/resource/lambda_function.rb:6:in tf': uninitialized constant Aws::Lambda (NameError)` @davidbegin

humayunjamal avatar Jan 14 '18 16:01 humayunjamal

Is anyone still working on this? It's been over a year.

tomisaacson avatar Feb 15 '19 20:02 tomisaacson

Bump? @dtan4 is there anything that can be done for this to be merged? @davidbegin any idea about the issue @humayunjamal posted above (https://github.com/dtan4/terraforming/pull/341#issuecomment-357524041)? Unfortunately I don't speak Ruby at all.

scream314 avatar May 20 '19 13:05 scream314