Don Syme

Results 1218 comments of Don Syme

@OlegAlexander My apologies, I missed the notifications. Yes, totally on the right track, please complete with Seq, Array etc. :))

@baronfel I tried to look into the test failures but I'm finding the engineering in this repo a bit difficult. * How do we actually see the output of tests?...

@baronfel I see thanks. Given how core this component is I do wonder if we should simplify a few things - e.g. remove Paket, remove `Ionide.KeepAChangeLog` whatever that is.

> but the Ionide.KeepAChangelog dependency is a valuable way to ensure that version numbers and release notes are a) kept, and b) included in all assembly and nuget package outputs...

I tried these: dotnet run --framework net6.0 --project test\Ionide.ProjInfo.Tests\Ionide.ProjInfo.Tests.fsproj dotnet run --framework net7.0 --project test\Ionide.ProjInfo.Tests\Ionide.ProjInfo.Tests.fsproj The first failed various tests with some errors due to .NET 7, the second with...

@baronfel OK thanks. I'll have to leave this for a while but does the change here look right? I'm really surprised we haven't needed this before. How else are our...

@baronfel From reading [these docs](https://github.com/dotnet/project-system/blob/main/docs/design-time-builds.md#targets-that-run-during-design-time-builds) it looks like we may need to add `ResolveFrameworkReferencesDesignTime` to [this list](https://github.com/ionide/proj-info/blob/main/src/Ionide.ProjInfo/Library.fs#L385-L390)??? I'd imagine this means Ionide is resolving to default framework references when doing...

> It seems to work in 6.0 Could you send me an example? After adding a global.json for 6.0.400 I see this: ``` C:\misc\t>dotnet --version 6.0.400 C:\misc\t>dotnet "c:\Program Files\dotnet\sdk\6.0.400\FSharp\fsi.dll" c:\github\dsyme\fsharp\tests\scripts\crackProject.fsx...

Thanks, how did you execute the code, via 'fsi' or a new project? Maybe my use of fsi is causing drama.

Such detective work, amazing! Resolving this will also allow us to get fsdocs support for F# 7 ready