zvault icon indicating copy to clipboard operation
zvault copied to clipboard

Lots of warnings with current rust release

Open wscott opened this issue 6 years ago • 0 comments

warning: the item `libc` is imported redundantly
   --> src/util/compression.rs:288:17
    |
288 |             use libc;
    |                 ^^^^
    | 
   ::: src/main.rs:37:1
    |
37  | extern crate libc;
    | ------------------ the item `libc` is already imported here
    |
    = note: #[warn(unused_imports)] on by default

warning: trait objects without an explicit `dyn` are deprecated
  --> src/util/hash.rs:38:38
   |
38 |     pub fn write_to(&self, dst: &mut Write) -> Result<(), io::Error> {
   |                                      ^^^^^ help: use `dyn`: `dyn Write`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/util/hash.rs:44:32
   |
44 |     pub fn read_from(src: &mut Read) -> Result<Self, io::Error> {
   |                                ^^^^ help: use `dyn`: `dyn Read`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/util/chunk.rs:43:38
   |
43 |     pub fn write_to(&self, dst: &mut Write) -> Result<(), io::Error> {
   |                                      ^^^^^ help: use `dyn`: `dyn Write`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/util/chunk.rs:51:44
   |
51 |     pub fn read_n_from(n: usize, src: &mut Read) -> Result<Self, io::Error> {
   |                                            ^^^^ help: use `dyn`: `dyn Read`

warning: `...` range patterns are deprecated
  --> src/util/hex.rs:15:17
   |
15 |             b'A'...b'F' => buf |= byte - b'A' + 10,
   |                 ^^^ help: use `..=` for an inclusive range
   |
   = note: #[warn(ellipsis_inclusive_range_patterns)] on by default

warning: `...` range patterns are deprecated
  --> src/util/hex.rs:16:17
   |
16 |             b'a'...b'f' => buf |= byte - b'a' + 10,
   |                 ^^^ help: use `..=` for an inclusive range

warning: `...` range patterns are deprecated
  --> src/util/hex.rs:17:17
   |
17 |             b'0'...b'9' => buf |= byte - b'0',
   |                 ^^^ help: use `..=` for an inclusive range

warning: trait objects without an explicit `dyn` are deprecated
  --> src/util/msgpack.rs:22:54
   |
22 | pub fn encode_to_stream<T: Serialize>(t: &T, w: &mut Write) -> Result<(), EncodeError> {
   |                                                      ^^^^^ help: use `dyn`: `dyn Write`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/util/msgpack.rs:35:59
   |
35 | pub fn decode_from_stream<'a, T: Deserialize<'a>>(r: &mut Read) -> Result<T, DecodeError> {
   |                                                           ^^^^ help: use `dyn`: `dyn Read`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/repository/mod.rs:84:18
   |
84 |     chunker: Box<Chunker>,
   |                  ^^^^^^^ help: use `dyn`: `dyn Chunker`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/cli/algotest.rs:35:40
   |
35 | fn chunk(data: &[u8], mut chunker: Box<Chunker>, sink: &mut ChunkSink) {
   |                                        ^^^^^^^ help: use `dyn`: `dyn Chunker`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunker.rs:47:33
   |
47 |     pub fn create(&self) -> Box<Chunker> {
   |                                 ^^^^^^^ help: use `dyn`: `dyn Chunker`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/fixed.rs:22:33
   |
22 |     fn chunk(&mut self, r: &mut Read, w: &mut Write) -> Result<ChunkerStatus, ChunkerError> {
   |                                 ^^^^ help: use `dyn`: `dyn Read`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/fixed.rs:22:47
   |
22 |     fn chunk(&mut self, r: &mut Read, w: &mut Write) -> Result<ChunkerStatus, ChunkerError> {
   |                                               ^^^^^ help: use `dyn`: `dyn Write`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/ae.rs:30:33
   |
30 |     fn chunk(&mut self, r: &mut Read, w: &mut Write) -> Result<ChunkerStatus, ChunkerError> {
   |                                 ^^^^ help: use `dyn`: `dyn Read`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/ae.rs:30:47
   |
30 |     fn chunk(&mut self, r: &mut Read, w: &mut Write) -> Result<ChunkerStatus, ChunkerError> {
   |                                               ^^^^^ help: use `dyn`: `dyn Write`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/rabin.rs:70:33
   |
70 |     fn chunk(&mut self, r: &mut Read, w: &mut Write) -> Result<ChunkerStatus, ChunkerError> {
   |                                 ^^^^ help: use `dyn`: `dyn Read`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/rabin.rs:70:47
   |
70 |     fn chunk(&mut self, r: &mut Read, w: &mut Write) -> Result<ChunkerStatus, ChunkerError> {
   |                                               ^^^^^ help: use `dyn`: `dyn Write`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/fastcdc.rs:78:40
   |
78 |     fn write_output(&mut self, w: &mut Write, pos: usize, max: usize) -> Result<ChunkerStatus, ChunkerError> {
   |                                        ^^^^^ help: use `dyn`: `dyn Write`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/fastcdc.rs:91:33
   |
91 |     fn chunk(&mut self, r: &mut Read, w: &mut Write) -> Result<ChunkerStatus, ChunkerError> {
   |                                 ^^^^ help: use `dyn`: `dyn Read`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/fastcdc.rs:91:47
   |
91 |     fn chunk(&mut self, r: &mut Read, w: &mut Write) -> Result<ChunkerStatus, ChunkerError> {
   |                                               ^^^^^ help: use `dyn`: `dyn Write`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/mod.rs:52:33
   |
52 |     fn chunk(&mut self, r: &mut Read, w: &mut Write) -> Result<ChunkerStatus, ChunkerError>;
   |                                 ^^^^ help: use `dyn`: `dyn Read`

warning: trait objects without an explicit `dyn` are deprecated
  --> src/chunking/mod.rs:52:47
   |
52 |     fn chunk(&mut self, r: &mut Read, w: &mut Write) -> Result<ChunkerStatus, ChunkerError>;
   |                                               ^^^^^ help: use `dyn`: `dyn Write`

warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred
   --> src/translation.rs:168:1
    |
168 | / lazy_static! {
169 | |     pub static ref EMBEDDED_TRANS: HashMap<&'static str, &'static[u8]> = {
170 | |         HashMap::new()
171 | |         //map.insert("de", include_bytes!("../lang/de.mo") as &'static [u8]);
...   |
177 | |     };
178 | | }
    | |_^
    |
    = note: #[warn(deprecated)] on by default
    = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred
   --> src/translation.rs:168:1
    |
168 | / lazy_static! {
169 | |     pub static ref EMBEDDED_TRANS: HashMap<&'static str, &'static[u8]> = {
170 | |         HashMap::new()
171 | |         //map.insert("de", include_bytes!("../lang/de.mo") as &'static [u8]);
...   |
177 | |     };
178 | | }
    | |_^
    |
    = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred
 --> src/util/encryption.rs:5:23
  |
5 | use std::sync::{Once, ONCE_INIT};
  |                       ^^^^^^^^^

warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred
  --> src/util/encryption.rs:20:21
   |
20 | static INIT: Once = ONCE_INIT;
   |                     ^^^^^^^^^ help: replace the use of the deprecated item: `Once::new()`

warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
   --> src/cli/mod.rs:102:9
    |
102 |         env::home_dir().unwrap().join(".zvault")
    |         ^^^^^^^^^^^^^

warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred
   --> src/cli/mod.rs:100:1
    |
100 | / lazy_static! {
101 | |     pub static ref ZVAULT_FOLDER: PathBuf = {
102 | |         env::home_dir().unwrap().join(".zvault")
103 | |     };
104 | | }
    | |_^
    |
    = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred
   --> src/cli/args.rs:349:17
    |
349 |         .author(crate_authors!(",\n"))
    |                 ^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred
   --> src/cli/args.rs:349:17
    |
349 |         .author(crate_authors!(",\n"))
    |                 ^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

warning: variable does not need to be mutable
   --> src/cli/mod.rs:946:17
    |
946 |             let mut repo = try!(open_repository(&repo_path, false));
    |                 ----^^^^
    |                 |
    |                 help: remove this `mut`
    |
    = note: #[warn(unused_mut)] on by default

    Building [=======================================================> ] 76/77: zvault(bin)                                          

wscott avatar Jul 18 '19 01:07 wscott