proquint icon indicating copy to clipboard operation
proquint copied to clipboard

Make Java version usable

Open mwanji opened this issue 10 years ago • 5 comments

I've looked a bit, but have not found a Java implementation aside from your own. I'd like to use it, but I'm not sure if it's meant to be used directly, or as an inspiration for other implementations? In either case, I'd be happy to help.

Things I'd like to do:

  • Give the classes a proper package name
  • Not use System.out or System.exit
  • Package it so that it can be distributed via Maven Central
  • Give it a friendlier interface

Would you want this as part of this repo or should I make my own?

mwanji avatar Oct 13 '14 13:10 mwanji

Putting it into my repo would be fine with me: I think it makes it easier for users if there is one place to find everything. You will of course get credit for your contribution. Is the 2-clause BSD license ok with you?

Daniel

On Mon, Oct 13, 2014 at 6:13 AM, Moandji Ezana [email protected] wrote:

I've looked a bit, but have not found a Java implementation aside from your own. I'd like to use it, but I'm not sure if it's meant to be used directly, or as an inspiration for other implementations? In either case, I'd be happy to help.

Things I'd like to do:

  • Give the classes a proper package name
  • Not use System.out or System.exit
  • Package it so that it can be distributed via Maven Central
  • Give it a friendlier interface

Would you want this as part of this repo or should I make my own?

— Reply to this email directly or view it on GitHub https://github.com/dsw/proquint/issues/1.

dsw avatar Oct 13 '14 20:10 dsw

Great. The license is fine with me.

mwanji avatar Oct 13 '14 20:10 mwanji

So I suppose the procedure is you fork my repo, add your feature, and then send me a pull request.

Daniel

On Mon, Oct 13, 2014 at 1:39 PM, Moandji Ezana [email protected] wrote:

Great. The license is fine with me.

— Reply to this email directly or view it on GitHub https://github.com/dsw/proquint/issues/1#issuecomment-58951379.

dsw avatar Oct 15 '14 07:10 dsw

Yes, my fork is https://github.com/mwanji/proquint

Question: I was thinking of having the main methods named encode and decode, as in https://github.com/deoxxa/proquint Are you OK with that?

mwanji avatar Oct 15 '14 07:10 mwanji

Sure: encode/decode is fine.

On Wed, Oct 15, 2014 at 12:19 AM, Moandji Ezana [email protected] wrote:

Yes, my fork is https://github.com/mwanji/proquint

Question: I was thinking of having the main methods named encode and decode, as in https://github.com/deoxxa/proquint Are you OK with that?

— Reply to this email directly or view it on GitHub https://github.com/dsw/proquint/issues/1#issuecomment-59166949.

dsw avatar Oct 15 '14 07:10 dsw