dsuponitskiy issues

Results 26 issues of


                                            dsuponitskiy

Changes for better rust compatibility

CMAKE_INSTALL_RPATH is not set correctly

see https://openfhe.discourse.group/t/bug-in-rpath-runpath-specification-in-cmakelists-txt/1071

bug

Code to be corrected

1. src/binfhe/include/rgsw-cryptoparameters.h: in RingGSWCryptoParams() instead of "if ((method == LMKCDEY) **&** (numAutoKeys == 0))" there should be "if ((method == LMKCDEY) **&&** (numAutoKeys == 0))" 3. FindInVector() is defined in...

bug

cleanup

Mark classes from "utils/exception.h" deprecated, so we can remove OPENFHE_THROW_OLD along with them.

Mention the deadline (Release 1.2.0)

cleanup

Mark MATHBACKEND=2 deprecated

cleanup

Change the type of m_statisticalSecurity and m_numAdversarialQueries to usint (rlwe-cryptoparameters.h)

m_statisticalSecurity and m_numAdversarialQueries are currently of the double type, but are meant to store integers. the type should be changed to usint/uint32_t.

Add bool member functions to CryptoContextImpl to examine scheme type

isCKKSRNS(), isBFVRNS(), isBGVRNS(). The functions defined in scheme-id.h can be used in the code

cleanup

Remove PublicKey from the parameter list

Remove PublicKey from the parameters passed to EvalAutomorphismKeyGen, EvalAtIndexKeyGen, EvalRotateKeyGen, EvalSumKeyGen, EvalSumRowKeyGen, EvalSumColsKeyGen as it is not used and make "privateKey" a const reference everywhere in that file

cleanup

Investigate if LWEEncryptionScheme's functions can be made static and m_LWEscheme can be remove from the BinFHEContext class

cleanup

review and fix if needed