VCRURLConnection icon indicating copy to clipboard operation
VCRURLConnection copied to clipboard

VCRURLConnection doesn’t consider request headers and body

Open 0xced opened this issue 10 years ago • 1 comments

VCRURLConnection doesn’t properly record requests if they have the same method and same URL but different headers and/or body. This is obvious when looking at the source code since VCRRequestKey is based on the URI and method properties only.

An example where this behavior becomes problematic is when using the Range header. Say you first ask for range 0-123 then you ask for range 0-12345. The second request will never be recorded because it’s considered equal to the first one since it has the same URL and same method.

I plan to work on this issue but before I start I’d like to know what’s the status of #16 as these issues are slightly related.

0xced avatar Mar 06 '14 22:03 0xced

Thanks @0xced. Agree that VCRRequestKey should be expanded to differentiate between these requests.

I believe this work and #16 can move forward independently. This work makes VCRRequestKey a more precise mapping to a single recording while #16 maps a single VCRRequestKey to multiple recordings.

dstnbrkr avatar Mar 18 '14 02:03 dstnbrkr