Stone-Soup icon indicating copy to clipboard operation
Stone-Soup copied to clipboard

Migrate to GitHub Actions

Open sdhiscocks opened this issue 1 year ago • 3 comments

This is a proposed change to migrate to GitHub Actions. The closer integration has some benefits over using CircleCI, such as easier linking and highlighting lines of code with flake8 errors, or which parts of the documentation have formatting errors. Having everything in one place and avoiding logging into another 3rd party service makes the checks easier for contributors to access.

One disadvantage is the documentation artefacts have to be downloaded, rather than viewed online. To consider is whether to keep CircleCI for this?

~~One minor issue, which I do not know the cause of, is GitHub Actions images (or possible a dependency) seems to have underflow errors (e.g. very small probabilities in things like particle filter going to zero), explicitly raised as an error, rather than ignored that seems to be default most everywhere else. Therefore there is an additional commit that explicitly sets underflow errors to be ignored in relevant places.~~

sdhiscocks avatar Mar 02 '23 14:03 sdhiscocks

Codecov Report

Patch coverage has no change and project coverage change: +0.15 :tada:

Comparison is base (7d31310) 94.85% compared to head (106061b) 95.00%.

:exclamation: Current head 106061b differs from pull request most recent head 114bc42. Consider uploading reports for the commit 114bc42 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   94.85%   95.00%   +0.15%     
==========================================
  Files         175      176       +1     
  Lines        9634    10006     +372     
  Branches     1915     2000      +85     
==========================================
+ Hits         9138     9506     +368     
- Misses        352      355       +3     
- Partials      144      145       +1     
Flag Coverage Δ
integration 68.48% <ø> (-0.44%) :arrow_down:
unittests 90.15% <ø> (+0.33%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stonesoup/sensormanager/reward.py 97.87% <ø> (ø)
stonesoup/types/orbitalstate.py 96.24% <ø> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Mar 02 '23 14:03 codecov[bot]

Looks good. Regarding the docs, could we host the built docs on a readthedocs subdomain or something similar to save having to sdownload them/keep CircleCI just for that use case?

Looks like that is an option. I'll look into it some more.

Also, on the issue with underflow, I've seen the issue elsewhere that on GitHub Actions, so I think it's a dependency that may be changing NumPy global default error state.

sdhiscocks avatar Mar 02 '23 17:03 sdhiscocks

Also, on the issue with underflow, I've seen the issue elsewhere that on GitHub Actions, so I think it's a dependency that may be changing NumPy global default error state.

Fixed just an hour ago https://github.com/geospace-code/pymap3d/issues/79

sdhiscocks avatar Mar 02 '23 18:03 sdhiscocks