Stone-Soup icon indicating copy to clipboard operation
Stone-Soup copied to clipboard

Contains method issue on CircleSamplePositionActionGenerator

Open sdhiscocks opened this issue 7 months ago • 0 comments

The inherited __contains__ method on CircleSamplePositionActionGenerator isn't suitable, as the action choices aren't discrete, and also values are generated randomly.

https://github.com/dstl/Stone-Soup/blob/458045c91819930bee2e8afe5b92e1cc34267a80/stonesoup/movable/action/move_position_action.py#L155-L156

__contains__ method should probably just check that the move is within the max travel radius.

sdhiscocks avatar Jun 02 '25 10:06 sdhiscocks