docker-ddns icon indicating copy to clipboard operation
docker-ddns copied to clipboard

Published 20 hours ago • verified publisher icon dstapp

Feature/expiry

Open sgyurko opened this issue 4 years ago • 4 comments

I implemented resource expiry (as one of your feature request was open for some time).

Can you please review and comment?

sgyurko avatar Dec 30 '19 19:12 sgyurko

Hey thanks for your PR. I'll review it and merge it. Unfortunately I'm a little short in time right now, but I'll get to it as soon as possible.

dstapp avatar Jan 12 '20 11:01 dstapp

Looks good.
The only issue I can see right now might be that having an expiry is forced.
Would it be possible to make it so it's not required?

BrainStone avatar Jan 15 '20 08:01 BrainStone

@sgyurko I'd also like to preserve the existing behavior in case nothing is defined. Can you make the initial expiry value -1 or something like that, meaning the records don't expire at all? I'm thinking about users that just pull this image on a regular basis and don't expect the configured behavior to change unless they explicitly opt in?

dstapp avatar Feb 23 '20 16:02 dstapp

I agree. Default behavior shouldn't change if possible. (And pretty sure it's possible)

BrainStone avatar Feb 23 '20 18:02 BrainStone