docker-ddns
docker-ddns copied to clipboard
Feature/expiry
I implemented resource expiry (as one of your feature request was open for some time).
Can you please review and comment?
Hey thanks for your PR. I'll review it and merge it. Unfortunately I'm a little short in time right now, but I'll get to it as soon as possible.
Looks good.
The only issue I can see right now might be that having an expiry is forced.
Would it be possible to make it so it's not required?
@sgyurko I'd also like to preserve the existing behavior in case nothing is defined. Can you make the initial expiry value -1 or something like that, meaning the records don't expire at all? I'm thinking about users that just pull this image on a regular basis and don't expect the configured behavior to change unless they explicitly opt in?
I agree. Default behavior shouldn't change if possible. (And pretty sure it's possible)