dstack icon indicating copy to clipboard operation
dstack copied to clipboard

Rename some of the YAML properties to shorter names

Open peterschmidt85 opened this issue 1 year ago • 7 comments

  1. spot_policy: spot|on-demand|auto -> spot: true|false|auto
  2. retry_policy: {retry: true|false, duration: int|str} -> retry_duration: int|str|off
  3. creation_policy: create|reuse|reuse-or-create -> reuse: false|true|auto
  4. termination_policy: dont-destroy|destroy-after-idle & termination_idle_time: int|str -> idle_duration: int|str|off
  5. pool_name: str -> pool: str

peterschmidt85 avatar Apr 20 '24 16:04 peterschmidt85

Looks good overall. Some notes:

  1. We're going to introduce new retry policies in #1200 so retry_duration alone is not sufficient. Let's do not touch retry_policy in this issue.
  2. Regarding creation_policy, we don't have creation_policy: create. The addition of new policy should be discussed outside of renaming issue. Also, it's unclear what reuse: false|true|auto means. reuse: true may be misleading since it doesn't simply allows reuse but forces it. creation_policy: reuse|reuse-or-create is more clear. I'm against renaming this particular field as suggested.

r4victor avatar May 07 '24 09:05 r4victor

retry_policy renamed in #1200

r4victor avatar May 30 '24 09:05 r4victor

This issue is stale because it has been open for 30 days with no activity.

peterschmidt85 avatar Jun 30 '24 01:06 peterschmidt85

This issue was closed because it has been inactive for 14 days since being marked as stale. Please reopen the issue if it is still relevant.

peterschmidt85 avatar Jul 14 '24 01:07 peterschmidt85

We still need to rename termination_idle_time: int|str -> idle_duration: int|str|off

peterschmidt85 avatar Jul 25 '24 20:07 peterschmidt85

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Aug 25 '24 01:08 github-actions[bot]