dstack
dstack copied to clipboard
Rename some of the YAML properties to shorter names
spot_policy: spot|on-demand|auto->spot: true|false|autoretry_policy: {retry: true|false, duration: int|str}->retry_duration: int|str|offcreation_policy: create|reuse|reuse-or-create->reuse: false|true|autotermination_policy: dont-destroy|destroy-after-idle&termination_idle_time: int|str->idle_duration: int|str|offpool_name: str->pool: str
Looks good overall. Some notes:
- We're going to introduce new retry policies in #1200 so
retry_durationalone is not sufficient. Let's do not touchretry_policyin this issue. - Regarding
creation_policy, we don't havecreation_policy: create. The addition of new policy should be discussed outside of renaming issue. Also, it's unclear whatreuse: false|true|automeans.reuse: truemay be misleading since it doesn't simply allows reuse but forces it.creation_policy: reuse|reuse-or-createis more clear. I'm against renaming this particular field as suggested.
retry_policy renamed in #1200
This issue is stale because it has been open for 30 days with no activity.
This issue was closed because it has been inactive for 14 days since being marked as stale. Please reopen the issue if it is still relevant.
We still need to rename termination_idle_time: int|str -> idle_duration: int|str|off
This issue is stale because it has been open for 30 days with no activity.