dgsh icon indicating copy to clipboard operation
dgsh copied to clipboard

Published 20 hours ago • verified publisher icon dspinellis

Update install-wrapped.sh

Open Gooberpatrol66 opened this issue 6 years ago • 4 comments

Line 52 echoes DESTDIR into wrapper scripts. When built in a sandbox, this breaks the dgsh programs after they have been moved out of the temporary install directory. Changed to fix.

Gooberpatrol66 avatar Jul 17 '18 01:07 Gooberpatrol66

Thank you! Could you perhaps look into the failing CI build? It could be irrelevant to your change, but I'd like to pull your change with a clean CI build.

dspinellis avatar Jul 17 '18 07:07 dspinellis

I looked at the log and I wasn't really sure what was causing the error.

Gooberpatrol66 avatar Jul 19 '18 02:07 Gooberpatrol66

Maybe a flakey test. I'm rerunning it.

dspinellis avatar Jul 19 '18 07:07 dspinellis

Are there any tests run inside the temporary install directory? This may have changed it from being broken while outside the temporary directory to being broken while inside the temporary directory.

Gooberpatrol66 avatar Jul 20 '18 18:07 Gooberpatrol66