go-exif icon indicating copy to clipboard operation
go-exif copied to clipboard

Can you tag with a Go Modules compatible version tag?

Open bep opened this issue 4 years ago • 6 comments

Seems like Go Modules is very picky about version format, it recognizes v3.0.0, but not 3.0.0.

bep avatar Jul 15 '21 14:07 bep

Valid point, though I feel like it might be more appropriate to do a major bump to v4.0.0 as an unrecognized/opaque version could be comparatively no different than a backwards-incompatible one. Thoughts?

dsoprea avatar Jul 17 '21 07:07 dsoprea

I'm currently traveling, so my responses can be delayed and I'll likely take no action in the next week.

dsoprea avatar Jul 17 '21 07:07 dsoprea

Thoughts?

A major bump would require a new "path update" (/v4), or whatever Go Modules calls it ... I would have just duplicated the tag, as both would point to the same Git ref (version). But that does not matter too much to me, as long as Go Modules are happy.

Also, no rush.

A little digression, but you have a little unusual project structure vs major versions. I suspect it would be easier to navigate and maintain if you just kept all versions in the root and just incremented in go.mod (and possibly also created a new default branch), but up to you.

bep avatar Jul 17 '21 09:07 bep

Bump; could you also have a look at #63 ... which is a blocker for pulling this library into Hugo. Thanks!

bep avatar Aug 31 '21 10:08 bep

Sure. I'll do it in the next couple of days. Sorry for the delay. This feel off my radar. Plus, it won't be enough to update this project, but also the constellation of tools and format-specific integrations that I've written against it, which will then affect even more people. I'll likely put a note in each project's README out of an abundance of caution.

dsoprea avatar Sep 05 '21 11:09 dsoprea

hey, looking forward to have working exif lib in hugo soon.

marang avatar Jan 24 '22 22:01 marang

Done. Pushed v3.0.1 .

dsoprea avatar Apr 22 '23 14:04 dsoprea

@bep We'll consider this (collapsing the current release-oriented paths) if we ever release v4.

https://github.com/dsoprea/go-exif/issues/62#issuecomment-881867613

dsoprea avatar Apr 22 '23 14:04 dsoprea