PySvn Use chdir before executing svn command

Permit to execute request like :

repo.list(False, '^/tags')

Feb 28 '17 20:02 GuillaumeSmaha

I am fixing some issues. Wait before review

Feb 28 '17 21:02 GuillaumeSmaha

Ok, I edit the test to add the main directories (trunk, tags and branches) in local repository and I add a test to list the tags directory with repo.list(False, '^/tags') from a local checkout on the trunk directory

Feb 28 '17 23:02 GuillaumeSmaha

I forgot that svn 1.6 have a .svn directory in each directory.

Mar 01 '17 19:03 GuillaumeSmaha

I squash the commits

Mar 01 '17 20:03 GuillaumeSmaha

@tusharmakkar08 Any news to merge this PR ?

Mar 18 '17 03:03 GuillaumeSmaha

Coverage decreased (-0.4%) to 70.332% when pulling 96732d21506602d736236cb893df5cca1f5ac80a on GuillaumeSmaha:use_chdir_instead_concat_path into 06de88419044f0241747f7259f440680992cfc22 on dsoprea:master.

Mar 20 '17 12:03 coveralls

Yes, preferably.

@dsoprea : Please look into this PR as well.

Thanks.

Mar 20 '17 12:03 tusharmakkar08

@tusharmakkar08 I replace finally by except and use raise to re-throw the exception. https://github.com/dsoprea/PySvn/pull/85/commits/90a261f6970cc9f327bd6ee3e3876a2d6c17347b#diff-557e034a141260ba6a3cd24b65e0f8cdR67

And I add a test to test this exception : https://github.com/dsoprea/PySvn/pull/85/commits/90a261f6970cc9f327bd6ee3e3876a2d6c17347b#diff-1d23cefe300b7c6f8845d87f328366adR185

Mar 20 '17 14:03 GuillaumeSmaha

@tusharmakkar08 I didn't know that finally also calls raise. I update to keep finally

Mar 20 '17 14:03 GuillaumeSmaha

Coverage decreased (-0.4%) to 70.332% when pulling 8082f6800472f7480ff71ba1e14cacaab9da3520 on GuillaumeSmaha:use_chdir_instead_concat_path into 06de88419044f0241747f7259f440680992cfc22 on dsoprea:master.

Mar 20 '17 14:03 coveralls

@GuillaumeSmaha : Please fix the failing test cases.

Mar 21 '17 12:03 tusharmakkar08

@tusharmakkar08 I don't know why, but sometimes the checkout doesn't work. I had the same issue on my computer before push it.

Update : I miss the error for python 2.7 : ERROR: Testing FileNotFoundError error with binary not found

Mar 21 '17 12:03 GuillaumeSmaha

Coverage decreased (-0.4%) to 70.332% when pulling bbe8a12df9e68f18efecb69b5a4cd26d791bcd10 on GuillaumeSmaha:use_chdir_instead_concat_path into 06de88419044f0241747f7259f440680992cfc22 on dsoprea:master.

Mar 21 '17 12:03 coveralls

Coverage decreased (-0.4%) to 70.332% when pulling 82ed194a806b30511e24d0bac1404a49543182cc on GuillaumeSmaha:use_chdir_instead_concat_path into 06de88419044f0241747f7259f440680992cfc22 on dsoprea:master.

Mar 21 '17 13:03 coveralls

Coverage decreased (-0.4%) to 70.332% when pulling 82ed194a806b30511e24d0bac1404a49543182cc on GuillaumeSmaha:use_chdir_instead_concat_path into 06de88419044f0241747f7259f440680992cfc22 on dsoprea:master.

Mar 21 '17 13:03 coveralls

@tusharmakkar08 I fixed the issue.

Mar 21 '17 13:03 GuillaumeSmaha

@tusharmakkar08 Any news to merge it ?

Jul 10 '17 23:07 GuillaumeSmaha

@dsoprea : Please look into this.

Jul 11 '17 03:07 tusharmakkar08

Coverage decreased (-0.5%) to 70.968% when pulling 8741d9327aa8dc1fac240720cd1ebd96608653e8 on GuillaumeSmaha:use_chdir_instead_concat_path into 95922a331d088312a8025f05d0a834f447b5f3d1 on dsoprea:master.

Oct 12 '17 18:10 coveralls

@dsoprea Could you review this PR ?

Apr 18 '18 21:04 GuillaumeSmaha

Please fix the conflicts and we can get this rereviewed.

Apr 23 '23 11:04 dsoprea

Closed due to stale conflicts.

Apr 23 '23 11:04 dsoprea

PySvn PySvn copied to clipboard

Use chdir before executing svn command

PySvn
PySvn copied to clipboard