David Snopek

Results 230 comments of David Snopek

Ok, I've removed the cherry-pick of PR https://github.com/godotengine/godot-cpp/pull/1357 for now

I also think it would be good to consolidate around a single version... I have my own too. :-)

Heh, I'm not saying we should use my version! But I think we should all talk and come up with a way to collaborate. I'm not personally worried about the...

Thanks for taking this on! It looks really cool :-) I did a quick test of the PR, and the "Compile on" checkbox didn't seem to work for me. It...

I don't think we can support calling `add_child()` in a constructor in godot-cpp, because depending on how the class was created, it won't be fully initialized at that point. I...

> Ah, is MultiplayerPeerExtension not useable outside an extension? You can extend `MultiplayerPeerExtension` in GDScript - the Nakama addon does it: https://github.com/heroiclabs/nakama-godot/blob/godot-4/addons/com.heroiclabs.nakama/utils/NakamaMultiplayerPeer.gd But unlike `NetworkedMultiplayerCustom` you have to make a...

Thanks for the report! I think what happened is that `MultiplayerPeerExtension` was added, and then later `_get_packet_channel()` and `_get_packet_mode()` were added, but they didn't get fully integrated into `MultiplayerPeerExtension`. I...

Ah, yes, I think that's still true. I added a note about it to the docs for `MultiplayerPeerExtension._get_unique_id()` in my latest push on PR #75116

Ah, sorry, I missed that CI is complaining about a `>` in the docs - it gives this patch to fix: ```diff diff --git a/doc/classes/EditorPlugin.xml b/doc/classes/EditorPlugin.xml index 9b0d239..577548e 100644 ---...

Thanks! At a high-level, I think this is a great addition, since it's making something that's possible via Godot modules also be possible via GDExtension (and addons). I'm not really...