David Snopek

Results 230 comments of David Snopek

I've done some further investigation on the flickering issue with Vulkan Mobile and a "Thread Model" of "Multi-Threaded". **First of all, the issue is NOT limited to Quest 3!** I've...

Something potentially interesting from `adb logcat` which I get when testing on both Quest 2 and Quest 3 (I didn't feel like retesting Quest Pro): ``` 04-10 11:26:08.669 7908 7992...

@akien-mga Thanks for the suggestion! I tried patching with the changes from PR https://github.com/godotengine/godot/pull/90268 (applied cleanly with some small offsets), and unfortunately, it doesn't fix the flickering. :-(

> I think it's pretty clear that this one is not going to be ready for 4.3, but we definitely need to see if we can get this over the...

@xwovr: Thanks for the suggestions! > If the app ignore the `shouldRender` flag, the side effect would be unnecessarily rendering the contents even the app is invislble, and waste performance...

@xwovr: > Instead of passing `XR_INFINITE_DURATION` to `xrWaitSwapchainImage` which can potentially trigger a deadlock, using a loop with high timeout value would be preferred. Here is an example code... I...

@BastiaanOlij: > So this suggest we're either still using `frame_state.shouldRender` in a method executed on the rendering thread, or there is something wrong in the way the rendering thread determines...

@BastiaanOlij What about this? ```diff diff --git a/modules/openxr/openxr_api.cpp b/modules/openxr/openxr_api.cpp index 4ced4196d1..150d7eb726 100644 --- a/modules/openxr/openxr_api.cpp +++ b/modules/openxr/openxr_api.cpp @@ -2156,7 +2156,7 @@ bool OpenXRAPI::pre_draw_viewport(RID p_render_target) { // We found an XR viewport!...

@BastiaanOlij: > Ok, rebased and applied both the swapchain fix and fixed up `pre_draw_viewport`. Also put a render thread guard onto `can_render`. Thanks! The latest is working great in my...

> Also I have had no chance at all to look into any issues with the compatibility renderer. Personally, I don't think we necessarily need to fix multi-threaded rendering with...