Joe Tsai
Overall, this package has held up well. If we were to ever consider a v2, here are some changes: * By default, always treat every variable as addressable, so that...
Standardizer wraps an io.Reader that reads from a HuJSON stream and implements an io.Reader that reads back standard JSON. Unlike the Standardize helper function, it does not validate HuJSON. It...
Currently, io.CopyBuffer uses WriteTo if the src supports it and ReadFrom if the dst supports it, presumably to avoid an allocation. The problem is that there exist certain io.ReaderFrom that...
The documentation is not clear whether a single table retrieved from `NewTable` can be passed to multiple `NewChunker` and be used concurrently. The logic in `rabin.go` seems to indicate that...
Re-use a pre-allocated bytes.Buffer struct and shallow the copy the result of bytes.NewBuffer into it to avoid allocating the struct. Note that we're only reusing the bytes.Buffer struct itself and...
Currently, the methods of a interface are not linkable because `Package.Parser` does not collect them up. Thus, if you put a declaration like `[Reader.Read]` within the `io` package, the `pkgsite`...
(I'm aware of #1057, but I believe I'm reporting a particular unchecked error that has low false positives) Consider a code that looks like the following: ```go if foo.WriteEntry(...); err...
I'm seeing a large number of error logs of the form: ``` ERROR piecestore upload internal error {"Process": "storagenode", "error": "manager closed: unexpected EOF", "errorVerbose": "manager closed: unexpected EOF\n\tgithub.com/jtolio/noiseconn.(*Conn).readMsg:225\n\tgithub.com/jtolio/noiseconn.(*Conn).Read:171\n\tstorj.io/drpc/drpcwire.(*Reader).read:68\n\tstorj.io/drpc/drpcwire.(*Reader).ReadPacketUsing:113\n\tstorj.io/drpc/drpcmanager.(*Manager).manageReader:230"} ```...
I propose the following helper method being added to `Mutex`: ```go // Do runs f under the protection of the mutex. func (m *Mutex) Do(f func()) { m.Lock() defer m.Unlock()...
If the client is connecting over loopback, then avoid the http-to-https redirect since this is connection within the kernel, rather than over untrusted network, and also because https://localhost is unlikely...