gridster.js icon indicating copy to clipboard operation
gridster.js copied to clipboard

Fix responsive issues due to using scrollWidth instead of clientWidth…

Open billschaller opened this issue 9 years ago • 3 comments

… - paddingLeft - paddingRight.

el[0].scrollWidth is definitely not the same as el.width().

scrollWidth returns the larger of either the width of the container or the width of the scrolling context, which is the width of the existing content in the element. Therefore, this change completely breaks responsive containers when resizing to a smaller width. Since the width of the content is larger than the new width of the container, this is not useful for sizing responsive containers.

The changes changing el.width() to el[0].scrollWidth should all be reverted. I've been trying to track the cause of responsive issues down for weeks off and on, and finally dedicated enough time today to find this...

billschaller avatar Jul 17 '15 21:07 billschaller

Is there a reason why this pull request has never been merged?

heartdisease avatar May 18 '16 12:05 heartdisease

initially It was because it conflicted with the webcomponents.js, but that has become moot, now it's because there is a merge conflict.

dsmorse avatar May 19 '16 02:05 dsmorse

@billschaller I know this is an old PR but would it be possible to discard the changes made at dist? dist is used so that upstream can offer an already built package to package managers, and should reflect the state of upstream. Other PR's could've changed that state before yours so it wouldn't be right to overwrite those changes.

fixmycode avatar Jul 19 '18 05:07 fixmycode