David Lecomber

I agree – I wasn’t aware of that one. I’ve tested that and it has the same effect as the other flag, performance looks good.

Hi @stschiff - thanks for working on this and for the update - great progress!

In the spack recipes for hdf5, the AMD compiler team have added this (see: https://github.com/spack/spack/pull/47123) ``` + # AOCC does not support _Float16 + if spec.satisfies("@1.14.4: %aocc"): + args.append(self.define("HDF5_ENABLE_NONSTANDARD_FEATURE_FLOAT16", False))...

in the CMake file for this.. ``` # dnl The output from the above program will be: # dnl -- LINE 1 -- valid integer kinds (comma separated list) #...

Thanks @brtnfld - I don't have the F90 chops myself to know what ought to have been the output. ACfL is built using the old PGI open sourced F90 compiler,...

The failure is that KIND=16 is not supported by ACfL, but that hdf5 thinks it is.

That's right - it doesn't compile: ``` [rocky@ip-10-11-42-205 ~]$ module load acfl Loading acfl/24.10.1 Loading requirement: binutils/14.2.0 [rocky@ip-10-11-42-205 ~]$ armflang test3.f90 F90-S-0081-Illegal selector - KIND parameter has unknown value for...

-1. ``` [rocky@ip-10-11-42-205 ~]$ cat >Test.f90 k = SELECTED_REAL_KIND(19,2) print*,k end [rocky@ip-10-11-42-205 ~]$ module load acfl Loading acfl/24.10.1 Loading requirement: binutils/14.2.0 [rocky@ip-10-11-42-205 ~]$ armflang Test.f90 [rocky@ip-10-11-42-205 ~]$ ./a.out -1 ```

Alas no joy: ``` ==> Using cached archive: /home/rocky/spack/var/spack/cache/_source-cache/archive/ec/ec2e13c52e60f9a01491bb3158cb3778c985697131fc6a342262d32a26e58e44.tar.gz ==> Applied patch /home/rocky/spack/var/spack/repos/builtin/packages/hdf5/acfl.kind16.patch ==> Ran patch() for hdf5 ==> hdf5: Executing phase: 'cmake' ==> hdf5: Executing phase: 'build' ==> Error:...

the text output of cmake is (as expected I think) unchanged: ``` -- Performing Test FORTRAN_CHAR_ALLOC - Success -- ....NUMBER OF INTEGER KINDS FOUND 4 -- ....REAL KINDS FOUND {4,8,16}...