David Joerg

When we fixed LotV, some of how we fixed it broke HotS. For example https://github.com/dsjoerg/ggpyjobs/commit/b913a3cdf23e9fb12a2d109c3222f62f17649878

Due to issues noted in #45

I handled the immediate problem with https://github.com/dsjoerg/ggpyjobs/commit/e117ff6de5104256fceee1b4b1ade1217a425ee9 but we could use a more comprehensive fix for other languages that may show up in the future.

One the one hand this would be cool, on the other hand I think you would find it frustrating because SQ is systematically higher for shorter games. (See http://ggtracker.com/spending_skill_stats#?race=protoss&gateway=am) So...

_From @agwblack on April 8, 2016 15:37_ So Spending Skill is just the SQ adjusted for game length? How does this work precisely?

See http://ggtracker.com/spending_skill

Not sure what the problem is exactly. From viewing the source of http://ggtracker.com/matches/6243833 it seems that the problem is not in the ggtracker codebase but in something upstream from there....

good idea, that is a popular request and may be a reasonable one for someone new to the codebase. as far as how to show it — one way would...

By the way, if anyone wants to work on this, have a look at https://github.com/dsjoerg/ggpyjobs/blob/master/sc2parse/sc2reader_to_esdb.py#L196 That's where we walk through the tracker_events and pick out the PlayerStatsEvents.

Or if you want a finer-grained look at whether a player is supply capped, you could walk through the finer-grained events of unit and building births and deaths.