Results 219 comments of Daniel Silhavy

Thanks for reporting, this requires a redesign of the Thumbnail logic in dash.js. Instead of having an individual ThumbnailController per period we need a global ThumbnailController for the complete stream....

@alexg-axis Thanks for pointing this out. We are aware that the `index.d.ts` is not completely in sync with the main code base. Can you provide the required changes for the...

@azeemmohd dash.js allows you to set the keys via the API as well: ```` function init() { const protData = { "org.w3.clearkey": { "clearkeys": { "nrQFDeRLSAKTLifXUIPiZg": "FmY0xnWCPCNaSpRG-tUuTQ" } } };...

@wilaw Thanks for reporting, I will try to reproduce this. I think we need to consider two things here: - There is `minPlaybackRateChange` parameter that defines the required difference between...

@wilaw Thank you for the feedback. I decided to go with option 1, see #4020 . I linearly scale the `minPlaybackRateChange` depending on the maximum playback rate. We still need...

@mattjuggins Thanks for reporting this. - I adjusted the API docs - We can add subattributes for `playbackRate` : `min` and `max` Can you create a PR for this?

Thanks @mattjuggins I left my code review in your PR. - I think we can leave the fallback rates as is, they have been like that for a while now...

PR has been merged, max of 200% sounds good it looks like this is what Youtube allows as well.