dshulyak

Results 131 issues of dshulyak

Example from devnet220. In layer 8521 2 smeshers voted for empty 8520 layer. There are actually many such examples. I can't trace the root cause without additional logging https://github.com/spacemeshos/go-spacemesh/issues/3134

Hare Protocol

Logging is pretty verbose even with INFO level. Setup rotation with some sensible limits, for example 1day of logging or 2gb of data https://github.com/natefinch/lumberjack

log

In particular, https://github.com/spacemeshos/go-spacemesh/blob/develop/tortoise/verifying.go#L203-L210 leads to 60Gb of memory allocated on the heap in an hour. The fix is simple, fields should be duplicated for every logline. Adding this issue as...

technical debt
log

https://github.com/spacemeshos/go-spacemesh/runs/4917192626?check_suite_focus=true

bug
Hare Protocol
high priority

Using zap is supposed to be fast and not allocation heavy, this benefit is negated by suboptimal patterns that are currently used in the codebase. More importantly all heavy allocations...

technical debt
log

https://github.com/spacemeshos/go-spacemesh/runs/4246970509 Can't find an error trace.

bug
Hare Protocol

``` hare.go:252: Unexpected call to *mocks.MockBeaconGetter.GetBeacon([2]) at /home/runner/work/go-spacemesh/go-spacemesh/hare/hare.go:252 because: expected call at /home/runner/work/go-spacemesh/go-spacemesh/hare/hare_test.go:271 has already been called the max number of times ``` https://github.com/spacemeshos/go-spacemesh/runs/4136098340?check_suite_focus=true

tests
Hare Protocol

hare module had a integration suite - https://github.com/spacemeshos/go-spacemesh/blob/v0.2.4-beta.0/hare/integration_test.go Integration suite was skipped and relied on simulator code in p2p module that was removed when libp2p integration got merged. I don't...

tests
technical debt

# Problem TestWhisperMailboxTestSuite/TestSyncBetweenTwoMailServers constantly fails on jenkins when tests are executed with race flag. Examples: https://ci.status.im/blue/organizations/jenkins/status-go%2Fprs%2Ftests/detail/PR-1404/2/pipeline ``` [2019-03-06T15:39:17.899Z] --- FAIL: TestWhisperMailboxTestSuite/TestSyncBetweenTwoMailServers (10.15s) [2019-03-06T15:39:17.899Z] :1: Error Trace: whisper_mailbox_test.go:555 [2019-03-06T15:39:17.899Z] Error: Received...

stale

# Problem We are sending envelope.sent event right after envelopes were successfully written to socket corresponding to the peer. Batch.acknowledged event is sent when peer reads those envelopes and responds...

stale