dshulyak

Results 197 comments of dshulyak

this change needs to be splitted before review

implemented elsewhere

> In order to hide the implementation details from the config, I can embed these structures in the main p2p Config instead of having separate fields. i don't know if...

@countvonzero i think existing interface for rerun was based on misinformed design. we definitely can't have just that interface. and most likely that interface is not even needed, because we...

yes basically about rerun > func rerun(ctx context.Context, from types.LayerID) error i don't understand how this interface can be supported using current implementation. rerun can start either from genesis, or...

> when syncer sees that is hash differ at layer N from a heavier weighted peer, and determine it should rerun from layer N how do you know the weight?...

> if rerun can start from genesis (which i assume is outside the sliding window), why can't it start from a random layer in this range (genesis, windowStart)? tortoise votes...

this will need to be implemented in the gossipsub fork if we will do it before genesis

validity is imported from the same peer or each layer from different? it won't work in the second case