puppetry icon indicating copy to clipboard operation
puppetry copied to clipboard

"wait for target" uses the selector, not the target

Open lawik opened this issue 3 years ago • 1 comments

This means that it also skips any parent targets defined for that target.

This increases the risk of false positives a fair bit. For us it lead to a very ugly bug for us where a specific xpath target would do the expected thing but a CSS target would hit widely on the page by ignoring its parent and pass when it shouldn't.

lawik avatar Jun 28 '21 14:06 lawik

Found the NOTE in the description while digging around the implementation. Realized that it is noted in the UI too. Not particularly clear for this use-case though and makes using chained targets/parents pretty much a footgun.

NOTE: This method is ignored by chained targets

lawik avatar Jun 28 '21 15:06 lawik