Daniel Gallups
Daniel Gallups
I also had the same question a while ago about this: https://github.com/rust-random/rand/pull/1609 In that discussion, this link was super helpful in understanding: https://stackoverflow.com/questions/62861623/should-cargo-lock-be-committed-when-the-crate-is-both-a-rust-library-and-an-exec. Hope this helps!
Inspecting the stream of messages, I went to see what was going on. Definitely a continuous stream, and I played a few keys quickly in succession in between: ```console 2024-12-06T04:07:37.668319Z...
Honestly, after looking into `midly`, I'm thinking about making an extension crate for them. I don't quite agree that *not* parsing the `u7` as a [particular key](http://www.music.mcgill.ca/~ich/classes/mumt306/StandardMIDIfileformat.html#BMA1_3) (like a Key...
@BlackPhlox Hate to ping! Could you look at this PR for me? I may take this crate in another direction, so might not be necessary. Just want to contribute a...
@johanhelsing Thanks for the approval! A lot of time has passed since this PR...I went ahead and built that [strongly typed parsing system](https://github.com/RustMIDI/midix/blob/1797e72c7a24151b3803b5abf0c6b4807c69b55d/src/events/live.rs#L48-L58). I believe the relevant code for this...
Had this issue, problem was a `Collider::rectangle` with a negative dimension.
https://github.com/dsgallups/midix/pull/39/commits/b04e0cb9f6ab9e4878d59542dc3ac1ed3fe8a0ee this commit could be useful edit: there's more to it [here](https://github.com/dsgallups/midix/pull/39/files). This might be a good testing ground to scope out different ideas. only difference prior to this linked...
- `RegionPair::get_start_address_offset`, `get_end_address_offset`, `get_start_loop_address_offset`, and `get_end_loop_address_offset` appear to be unused seems like instances of those methods are found in the sanity check for `Region`. - `Voice`'s `sample_rate` is unused...wonder if...
- Seems like `VolumeEnvelope` and `ModulationEnvelope` behave identically, with the exception that `VolumeEnvelope` holds a priority. They're only found in Voice. Might be wrong here, but I think these structs...
> [VolumeEnvelope::Process()](https://github.com/sinshu/rustysynth/blob/979b14758289bd42f4deac117b784c7013cfaf6f/rustysynth/src/volume_envelope.rs#L85C19-L85C27) returns a bool that is used, but it's hard to understand what for. See `VoiceCollection::process`. It appears that if a voice has returned true, and i is equal...