Douglas Senalik
Douglas Senalik
The importer selector is strangely fussy. If you don't wait for the ajax to complete, then the autocomplete doesn't work. Also, the dropdown list does not reflect the letter(s) entered...
These are commonly showing up and I wonder if additional special processing is needed as is done with 'Language': [!] Overall missing CVTERMS for this set of publications: Author List,Uniquename...
Task list for future or for this PR, not sure yet - [x] Overall missing CVTERMS for this set of publications: Author List - [x] Unprocessed publication keys that are...
Test coverage for tripal_chado/src/Plugin/TripalImporter/PubSearchQueryImporter.php and tripal/src/TripalPubParser/TripalPubParserBase.php, is not ideal but removing draft status
Thank you for the review @reynoldtan - I'm working through this slowly. Current progress: > Hi @dsenalik, as requested by Lacey to review this PR, here is my review of...
> 5. Field value from one summary list to another shows a different value for the same field (column header is a mismatched too). Fixed with https://github.com/tripal/tripal/pull/1960/commits/469336b12139065f46288c01b4df28db8877c5ef > 6. There...
I have never been very happy with having two menu options for the publication importer. With some recent changes, it is now only one. The main menu item **"Publication Loader"**...
The import to the pubauthor table had not yet been implemented. I added that, as well as the do_contact setting is now implemented. In the process, I massively rewrote the...
@reynoldtan If you are willing to re-review the PR is ready again Thanks Doug
> * Columns Create Contact and Disabled can be further improved by using Yes/True for 1 and No/False for 0. I do not see the 0|1 appearing, what version of...