Douglas Senalik

Results 204 comments of Douglas Senalik

I noticed this comment, I had reason to remove a module (BIMS, didn't support chado 1.3) and it took me some time to clean up the CV and DB entries,...

From a code review of `OBOImporter.php` it looks like we will only need to provide: * NCIT:C25693 * rdfs:comment * a DB named 'synonym_type' * a CV named 'synonym_type'

My working notes about the files for this importer ## INSTALLATION FILE: `tripal/tripal.install` 🠚 define the new table `tripal_pub_import` ## MENU ITEMS ### JOB RUNNER FILE: `tripal_chado/src/Plugin/TripalImporter/ChadoPubImporter.php` 🠚 Plugin for...

New design for the publication loader - see https://github.com/tripal/tripal/issues/1595#issuecomment-1677701789 > Summary of discussion on 8/14/2023 in the Tripal Dev file > > For publications > - Create a base class...

Closing as this was nicely done with merged PR #1604

This sounds like a great improvement, especially since it is backwards compatible. I would prefer consistency in all of the linker tables. A few linker tables also have a `rank`...

I have hopefully resolved the three noted problems 1. I removed the first of the two duplicated fields with commit https://github.com/tripal/tripal/pull/1871/commits/f149c96433349f7126123703223997ba4782ce04 - the second one is more logically placed and...

3. I changed `assay_name` (used for Assay title) to plain text to resolve the last remaining title with <p></p> tags, commit https://github.com/tripal/tripal/pull/1871/commits/9cf6bfc86e174daebac7804dc47cdb0ee0e56817

I wrote a program to scan all the yaml just to make sure there are no others - that seems to be the only case - thanks for finding it!

For item 2: Thanks @laceysanderson for calling me out on that function, what it really did was just confirm that a bundle existed with the same name as the base...