Douglas Senalik

Results 126 comments of Douglas Senalik

I am assuming that we cannot add a Chado field on a Drupal content type, because it won't have a Chado base table. And that we just need to catch...

I started working on this, because it has always bugged me that these are combined 😡 There are some severe performance issues with `chado_insert_property` and `chado_insert_dbxref`. Since these are only...

**Some design notes.** - Split into two importers: ![2024-07-15_taximporter](https://github.com/user-attachments/assets/8989b69c-1da2-4e72-a60a-627646c0f0f5) ![2024-07-15_treegenerator](https://github.com/user-attachments/assets/1be8f3c6-87ce-497b-8777-8db6ed0b5604) - Only the NCBI taxonomy importer will contact NCBI, the tree generator will use information stored in chado. - To...

Here's another example, probably from a different location in the code. Since it's in drupal not much we can do... ``` Running composer update drupal/core drupal/core-dev drush/drush phpspec/prophecy-phpunit drupal/devel drupal/devel_php...

for instance: 1) Drupal\Tests\tripal_chado\Functional\TaxonomyImporterTest::testTaxonomyImporterSimpleTest fopen(https://www.ncbi.nlm.nih.gov/entrez/eutils/efetch.fcgi?db=taxonomy&id=3702): Failed to open stream: HTTP request failed! HTTP/1.1 400 Bad Request This is interesting because the taxonomy importer uses retry loops, it will attempt three...

~I bet this is a php version issue, before the retry would work, maybe now it triggers an exception~ ~I'm beginning to think we are just getting to three retries...

Lacey, I fixed this, at least for the taxonomy importer. Please check out the tiny change in pr #1679 that fixes it. I should still add retry loops to some...

Referencing Lacey's comment from the PR https://github.com/tripal/tripal/pull/1679#pullrequestreview-1718265923 I should investigate if this is a better option or not.

**To-Do List** I tested **all** content types manually, the following need organism added (of the feature types, only **Gene** is okay) * **Genetic Marker** _fixed with #1555_ * **Phenotypic Marker**...

And it has always bugged me, so I am reordering the **organism** fields so we have Genus - species - infraspecific_type - infraspecific_name in that order and together 😛