text2vec icon indicating copy to clipboard operation
text2vec copied to clipboard

GlobalVectors object lost fit method?

Open geotheory opened this issue 4 years ago • 3 comments

Hey there. I find your example from Feb no longer works for me (macOS 11.0.1, version 4.0.3, text2vec 0.6).

require(text2vec)
#> Loading required package: text2vec
glove = GlobalVectors$new(rank = 50, x_max = 10)
glove$fit
#> NULL

In your example script, replacing glove$fit() line with glove$fit_transform() does train the model. But next line fails:

word_vectors <- glove$get_word_vectors()
Error: attempt to apply non-function

because glove$get_word_vectors is also missing. Any idea what is going on?

geotheory avatar Dec 26 '20 15:12 geotheory

Thanks for reporting, I will take a look.

On Sat, 26 Dec 2020, 19:49 Robin Edwards, [email protected] wrote:

Hey there. Is this package still maintained?

I find your example https://cran.r-project.org/web/packages/text2vec/vignettes/glove.html from Feb no longer works for me (macOS 11.0.1, version 4.0.3, text2vec 0.6).

require(text2vec) #> Loading required package: text2vec glove = GlobalVectors$new(rank = 50, x_max = 10) glove$fit #> NULL

In your example script https://cran.r-project.org/web/packages/text2vec/vignettes/glove.html, replacing glove$fit() line with glove$fit_transform() does train the model. But next line fails:

word_vectors <- glove$get_word_vectors() Error: attempt to apply non-function

because glove$get_word_vectors is also missing. Any idea what is going on?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dselivanov/text2vec/issues/329, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHC5XKE4KCNTJVZGUSONFDSWYAYLANCNFSM4VKAFRGA .

dselivanov avatar Dec 26 '20 15:12 dselivanov

I just noticed the vignette has changed since that example. April version is up to date.

geotheory avatar Dec 26 '20 19:12 geotheory

Yes, I need to update CRAN version to fix some documentation issues. This issue seems duplicate for #323. I will keep it open until I update pkg on CRAN.

dselivanov avatar Dec 27 '20 07:12 dselivanov