Dan Schult
Dan Schult
I'm going to close this PR so it doesn't take more review cycles. The problem with this approach is that it changes the NX provided edge matching functions so they...
@Transurgeon do you have any insights on this discussion about `tree broadcasting` vs `broadcasting`? See [related comment from the original PR](https://github.com/networkx/networkx/pull/6928#issuecomment-1896467857) for broadcasting.
When you say "scales poorly" I assume you mean that the computation time scales poorly -- not that memory scales poorly -- just checking. My naive intuition makes it seem...
Check the documentation at: https://networkx.org/documentation/stable/reference/algorithms/similarity.html If gives some alternatives. This is a hard problem (indeed it is NP-hard) so each algorithm has specific graph formations which make it very slow....
There seems to be a reasonable article discussing the issue of accuracy of heuristic methods for computing GED. They look at the accuracy defined as how much it affects a...
Maybe we should add an example to that general recommendation. Something like: ```python old_wts = nx.get_edge_attributes(G, "weight") new_wts = {e: round(1e8 * wt) for e, wt in old_wts.items()} nx.set_edge_attributes(G, new_wts,...
Good idea! A weight function is a great place to adjust the weights without creating or updating edge attributes. Something like (untested): ```python def dodge_weight_roundoff(u, v, data_dict): return round(1e8 *...
NetworkX tests environments without any dependencies (even numpy) because some of our users want no dependencies. To allow those tests to pass for code that does use dependencies like numpy...
You should have a `seed` argument for any function that uses random number generators (or calls another function that uses random number generators). We absolutely need to allow people to...
Nice idea to merge directed steiner tree with the original steiner tree -- but I think in this case the function signatures are sufficiently different and the logic/code seem completely...