Dan Schult
Dan Schult
In #20249 the problem is the code explicitly uses int32 (ITYPE_t) arguments which doesn't allow `long` type. I think of that as a lack-of-templating problem, but I am not very...
To summarize (hopefully correctly). There are multiple ways to define uniformly chosen random directed trees in the literature. Even the definition of a directed tree varies (arborescence vs polytree for...
Thanks for this! It's not in a format ready for networkx yet, but there is some good code there. Let's talk about the big picture ideas first: Did you look...
With #7432 merged, this should be rebased-on/merged-with main and will hopefully pass the dispatch tests now that nx-loopback preserves edge order when converting during the tests. I don't think there...
What I think this discussion is leading toward is the following: - the `compute_v_structures` function should appear in the main namespace raise a deprecation warning and call `nx.dag.colliders` - the...
Thanks for this @padath314 and @Sreelaxme (and for the bipartite PR). These are interesting algorithms. I hope to get to take a closer look soon. :)
It looks to me like the doc_string does not match the function behavior. The function seems to compute triples where the two outer nodes have directed edges to the middle...
I agree with @rossbar that this check doesn't really have a down side -- and it allows a non-prime p to construct a graph in the same way that a...
Thanks for this report! This is a blast from the past. I suspect it is the change from `subgraph` constructing a graph to the "new" view based system. In v2.0+,...
I took a look at the PR and I think it is changing the interface in a way I find confusing at first glance. Perhaps I am missing something --...