Dan Schult
Dan Schult
This was designed this way to avoid backward incompatibility. But of course now it is an inconsistency. We should probably do something.... The thinking was as follows: MultiGraphs should have...
What's your goal for having deterministic ```simple_cycles()```? Often when there is a problem that doesn't have a good solution, there's another problem that could alleviate the need to solve the...
Hmmm... Another approach which is similar to sorting scc but doesn't involve a sort -- but does involve many ```__contains__``` operations: ```scc = [n for n in G if n...
As you explore this again, I'll just note that you shouldn't worry too much about relying on a "detail of CPython implementation" with regard to deterministic hashes for integers. dict...
Thanks @NeilGirdhar ! This really helps give a feel for the impact of this change. Given the feedback I've heard from multiple sources, this or something like this will likely...
The reason we use the awkward looking code (and others): ``` self.graph_attr_dict_factory = self.graph_attr_dict_factory ``` is for speed (it becomes an instance attribute instead of a class attribute) but I'm...
For the slowdown in `G.copy` the benchmark copies an empty graph. The slowdown goes away if the graph has some edges. I think this is due to the changed lines:...
Would it be possible to rerun the benchmarks on PR #5836 ? I'm not sure how involved that is. I ran some timing tests locally and it seemed to fix...
Is the performance regression in the core classes still there?
You shouldn't get that message unless something weird is going on. Is this a single graph, or with more than one graph? Is there any info you can give us...