Dan Schult

Results 516 comments of Dan Schult

Aha! Thanks for this -- the `inspect.stack()` must try to access attributes on the modules. It is probably looking for something like `__file__`. But as soon as the module tries...

I went through this code and it looks like we expect `mapping` to provide: `__getitem__, keys, items, values, get, __contains__`. So the only methods from `abc.Mapping` we are not using...

That seems good, too. Technically it does change the current logic if a previous user inputs a class that is both a Mapping and a Callable. They get the callable...

Thank you very much for reporting this!! This is a very strange an ugly bug. It stems from the function yielding a list-of-sets without copying those sets. When the next...

My notes say that it is indeed better to save the labels and degrees as dicts (thanks @mriduls for the nudge on that). Also, a **really** helpful utility from NetworkX...

A more compact way of coding the computation of set T1 might be: ```python T1 = {nbr for node in m for nbr in G1[node] if nbr not in m}...

Regarding cutting rules: The paper is solving many different problems, including ISO (are 2 graphs isomorphic), IND (is one graph isomorphic to an induced subgraph of the other graph) and...

Perhaps we can use better words to describe T1, T2, T1_tilde and T2_tilde. T1 - seen1 (unmapped neighbors of mapped nodes) T1_tilde1 - unseen1 (not a neighbor of any mapped...

@kpetridis24, you mentioned four lines that could replace the long for-loop that computes the argmax of used_degree with ties. And you asked if it looked right. And I wasn't able...

Hi @kpetridis24, Can you move the commits you are working with into the VF2++ branch and push them up to your repo? That will update the PR and we can...